Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scarb check instead of scarb build in cairo listings verification script #2718

Open
franciszekjob opened this issue Nov 26, 2024 · 0 comments · May be fixed by #2726
Open

Use scarb check instead of scarb build in cairo listings verification script #2718

franciszekjob opened this issue Nov 26, 2024 · 0 comments · May be fixed by #2726
Labels
documentation Improvements or additions to documentation new

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 26, 2024 •
edited
Loading

Which component is your feature related to?

Other (Please describe below)

Feature Request

Blocked by software-mansion/scarb#1779

Currently run scarb build (due to issue above), ultimately we should run scarb check. Once it's resolved, we should update https://github.com/foundry-rs/starknet-foundry/blob/master/scripts/verify_cairo_listings.sh
@franciszekjob franciszekjob added documentation Improvements or additions to documentation blocked labels Nov 26, 2024
@github-actions github-actions bot added the new label Nov 26, 2024
@franciszekjob franciszekjob changed the title Remove building snforge scarb plugin while testing docs Change scarb build to scarb check in cairo listings verification script Nov 26, 2024
@franciszekjob franciszekjob changed the title Change scarb build to scarb check in cairo listings verification script Use scarb build to scarb check in cairo listings verification script Nov 26, 2024
@franciszekjob franciszekjob changed the title Use scarb build to scarb check in cairo listings verification script Use scarb check instead of scarb check in cairo listings verification script Nov 27, 2024
@franciszekjob franciszekjob changed the title Use scarb check instead of scarb check in cairo listings verification script Use scarb check instead of scarb build in cairo listings verification script Nov 27, 2024
@franciszekjob franciszekjob linked a pull request Nov 27, 2024 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation new
Projects
Starknet foundry
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use scarb check instead of scarb build foundry-rs/starknet-foundry
1 participant
@franciszekjob