Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex and logic for snippet capturing #2713

Open
franciszekjob opened this issue Nov 26, 2024 · 2 comments
Open

Update regex and logic for snippet capturing #2713

franciszekjob opened this issue Nov 26, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation feature New feature request/description new

Comments

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 26, 2024

Which components does the task require to be changed? (think hard pls)

other

Description

Currently, snippets are captured by regex which should start with $ snforge/sncast .... However, this doesn't allow for other cases, e.g.

$ SNFORGE_BACKTRACE=1 snforge test

Snippets capturing and internal logic could be possibly reworked to allow such cases.

@franciszekjob franciszekjob added the documentation Improvements or additions to documentation label Nov 26, 2024
@github-actions github-actions bot added the new label Nov 26, 2024
@ksew1 ksew1 mentioned this issue Nov 26, 2024
5 tasks
@cptartur cptartur added feature New feature request/description new and removed new labels Nov 26, 2024
@petersdt
Copy link

@cptartur @franciszekjob can i jump on this

@franciszekjob
Copy link
Collaborator Author

Hey @petersdt , thanks for applying, however we mostly accept applications for tasks marked with "help wanted" or "good first issue" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature request/description new
Projects
Status: New
Development

No branches or pull requests

3 participants