Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

note(config): stop overloading foundry.toml and provide namespaces for superfluous settings #9556

Open
sambacha opened this issue Dec 14, 2024 · 1 comment
Open

note(config): stop overloading foundry.toml and provide namespaces for superfluous settings #9556

sambacha opened this issue Dec 14, 2024 · 1 comment
Labels
A-config Area: config T-feature Type: feature T-likely-breaking Type: requires changes that can be breaking
Milestone
v1.0.0

Comments

@sambacha
Copy link
Contributor

Component

Forge

Describe the feature you would like

foundry.toml seems to just have whatever latest feature jammed right into the global namespace for configuration, e.g. odyssey = false. I have no idea what is, it should be a child of a parent namespace. It should provide descriptive information such that I don't have to dig around to see what it is and why its causing me an error on updating forge.

it certainly does not belong in the [profile.default] namesapce.

Additional context

No response
@sambacha sambacha added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Dec 14, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 14, 2024
@zerosnacks zerosnacks added T-likely-breaking Type: requires changes that can be breaking and removed T-needs-triage Type: this issue needs to be labelled labels Dec 18, 2024
@zerosnacks
Copy link
Member

zerosnacks commented Dec 18, 2024 •
edited
Loading

Hi @sambacha thanks for raising this, I agree we should be mindful of the global namespace

I think we should address this as part of a larger set of major breaking changes we want to make for 1.0.

The odyssey flag relates to enabling Odyssey's fork-ahead experimental features (PragueEOF).

@zerosnacks zerosnacks added this to the v1.0.0 milestone Dec 18, 2024
@zerosnacks zerosnacks added the A-config Area: config label Dec 18, 2024
@zerosnacks zerosnacks changed the title Feat: stop overloading foundry.toml and provide namespaces for superfluous settings note(config): stop overloading foundry.toml and provide namespaces for superfluous settings Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-config Area: config T-feature Type: feature T-likely-breaking Type: requires changes that can be breaking
Projects
Foundry
Status: Todo
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@sambacha @zerosnacks