Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: forge coverage not fully compatible with forge test commands #9525

Open
2 of 7 tasks
zerosnacks opened this issue Dec 9, 2024 · 2 comments
Open
2 of 7 tasks
Assignees
Labels
C-forge Command: forge Cmd-forge-coverage Command: forge coverage Cmd-forge-test Command: forge test T-bug Type: bug

Comments

@zerosnacks
Copy link
Member

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

forge coverage

Operating System

Linux

Describe the bug

Expected to be compatible with:

Not expected but should be marked as incompatible:

  • --junit
  • --debug (is ignored), same for --framegraph and --flamechart
  • --list (runs coverage but returns as 0% hitrate)

forge snapshot appears to be fully compatible

It is confusing that these options are available

@zerosnacks zerosnacks added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 9, 2024
@zerosnacks zerosnacks added Cmd-forge-test Command: forge test Cmd-forge-coverage Command: forge coverage C-forge Command: forge and removed T-needs-triage Type: this issue needs to be labelled labels Dec 9, 2024
@zerosnacks zerosnacks self-assigned this Dec 9, 2024
@DaniPopes
Copy link
Member

There are multiple JSON coverage formats (see https://docs.codecov.com/docs/supported-report-formats), and I don't think we should invent one for our own, so at the very least it should be a --format <some JSON format> flag.

@sakulstra
Copy link
Contributor

sakulstra commented Dec 13, 2024

uhh, format --json would be quite nice.
For aave dao we're currently using lcov-parse node package to transform from lcov.info to json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-coverage Command: forge coverage Cmd-forge-test Command: forge test T-bug Type: bug
Projects
Status: Todo
Development

No branches or pull requests

3 participants