Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clearer error message when function signature does not contain parentheses #9479

Open
yipu3 opened this issue Dec 4, 2024 · 1 comment · May be fixed by #9478
Open

chore: clearer error message when function signature does not contain parentheses #9479

yipu3 opened this issue Dec 4, 2024 · 1 comment · May be fixed by #9478
Labels
C-cast Command: cast T-chore Type: chore

Comments

@yipu3
Copy link

yipu3 commented Dec 4, 2024

Component

Cast

Describe the feature you would like

When I wrongly input a function signature without parentheses:

./target/debug/cast call 0x7a250d5630B4cF539739dF2C5dAcb4c659F2488D 'deposit'

The error message is a bit of confusing:

Error: If you wish to fetch function data from EtherScan, please provide an API key.

And cost me some time the figure out what's the point.

A clearer error message is needed.

Additional context

No response
@yipu3 yipu3 added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 4, 2024
@yipu3
Copy link
Author

yipu3 commented Dec 4, 2024 •
edited
Loading

Have created a pr to fix.
#9478

@grandizzy grandizzy linked a pull request Dec 4, 2024 that will close this issue
Open
@zerosnacks zerosnacks added C-cast Command: cast and removed T-needs-triage Type: this issue needs to be labelled labels Dec 4, 2024
@zerosnacks zerosnacks changed the title clearer error message when function signature does not contain parentheses chore: clearer error message when function signature does not contain parentheses Dec 4, 2024
@zerosnacks zerosnacks added T-chore Type: chore and removed T-feature Type: feature labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cast Command: cast T-chore Type: chore
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: clearer error message when function signature does not contain parentheses yipu3/foundry
2 participants
@yipu3 @zerosnacks