Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature that makes inclusion of "fail" in test name cause the test to always fail. #9218

Closed
mgiagante opened this issue Oct 28, 2024 · 3 comments
Closed

Remove feature that makes inclusion of "fail" in test name cause the test to always fail. #9218

mgiagante opened this issue Oct 28, 2024 · 3 comments
Labels
T-feature Type: feature T-post-V1 Area: to tackle after V1 T-to-discuss Type: requires discussion

Comments

@mgiagante
Copy link
Contributor

Component

Forge

Describe the feature you would like

Currently, including the word "fail" in the name of a test makes the test always expect a revert. This is counter intuitive as some users might add this word in the test name to describe the intent of the case or the scenario under test.

Unless there is a strong case for keeping this, its removal would make forge test more intuitive.

Additional context

No response
@mgiagante mgiagante added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Oct 28, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 28, 2024
@mgiagante
Copy link
Contributor Author

I want to volunteer to fix this.
Feel free to assign it to me if you want. Thanks!

@grandizzy grandizzy added T-to-discuss Type: requires discussion T-post-V1 Area: to tackle after V1 and removed T-needs-triage Type: this issue needs to be labelled labels Oct 29, 2024
@zerosnacks
Copy link
Member

This is a breaking change with DappTools compatibility that we are intending to make after the V1 release

@grandizzy
Copy link
Collaborator

Closing this one as dupe of #4437

@grandizzy grandizzy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature Type: feature T-post-V1 Area: to tackle after V1 T-to-discuss Type: requires discussion
Projects
Foundry
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgiagante @grandizzy @zerosnacks