Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist of things that need to be done #536

Closed
31 of 36 tasks
gakonst opened this issue Jan 22, 2022 · 16 comments
Closed
31 of 36 tasks

Checklist of things that need to be done #536

gakonst opened this issue Jan 22, 2022 · 16 comments
Labels
T-meta Type: meta

Comments

@gakonst
Copy link
Member

gakonst commented Jan 22, 2022

Quick braindump of things we should do in terms of docs / PM moving forward

  • FAQ Doc
    • foundryup vs cargo/bin installation path (either delete the .cargo/bin or set .foundrup/bin before it in your PATH)
    • i cannot see my logs (need to trigger verbosity)
    • how do I fork mainnet state? (--fork-url)
    • how do gas snapshots work?
    • how do I use a manual solc version? (--offline / --no-auto-detect / SOLC_PATH / PATH)
    • how to use console.sol (need to vendor it)
    • how do I run specific tests / contracts? (--match / --match-contract etc.)
  • Patterns doc
  • Known Issues Doc
    • caching bug
    • fuzzer edge cases
    • missing libusb
  • Improved Issue Template
    • How did you install foundry?
    • What is the exact set of commands that you ran to get the bug?
    • If it's a Solidity repo, do you have a minimal code example?
    • Did you check the FAQ?
    • Is this a Foundry question, or are you making a Solidity mistake?
  • PR Template
    • Motivation
    • Solution
  • Projects
    • Deploy
    • Etherscan Verification
    • Symbolic EVM
    • Improved Fuzzer
    • Mutation Testing
    • Coverage
    • Gas Reports
    • Refactor to be abstract over Compiler and Runtime (set up StarkNet support)
    • Solidity Book using Foundry
    • Foundry Book

What else are we missing?

@gakonst gakonst changed the title docs checklist Checklist of things that need to be done Jan 22, 2022
@gakonst gakonst added the T-meta Type: meta label Jan 22, 2022
@mattsse
Copy link
Member

mattsse commented Jan 22, 2022

meta:

pending features

@alephao
Copy link
Contributor

alephao commented Jan 22, 2022

On the FAQ doc, any idea on how that should be structured? Just dump on README.md for now and figure out later?

Happy to work on those to help out:

Edit: logs seem to be well explained here https://github.com/onbjerg/foundry-book/blob/master/src/forge/traces.md

@onbjerg
Copy link
Member

onbjerg commented Jan 23, 2022

  • Debugging for tests with parameters (to debug fuzz tests)

@mds1
Copy link
Collaborator

mds1 commented Jan 23, 2022

A few other things I'd find useful that I'd like to be on this list:

@onbjerg
Copy link
Member

onbjerg commented Jan 23, 2022

(Note: The fix for mockCall would require a rewrite to use revm over Sputnik which is a big task)

@EricForgy
Copy link

What else are we missing?

Maybe a VS Code extension?

I was happy to learn about foundry.toml and put my remappings in there. It compiles and runs fine, but VS Code doesn't yet recognize the remappings (red triggering squiggles) and putting them in workspace settings doesn't feel great. I ended up moving back to remappings.txt temporarily.

@ultrasecreth
Copy link

Filesystem cache when running on a fork from mainnet (like hardhat), the amount of RPC requests and the time that it takes when iterating over a test is quite significant (currently >60s on some test I'm working on).
For what I can see there's an in-memory cache so running a full test suite doesn't get that bad, but when writing a test you normally have to run it many times so it gets annoying to wait 30s or more each time.

@onbjerg onbjerg added this to Foundry Apr 17, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 17, 2022
@appleseed-iii
Copy link
Contributor

what do you think about removing the leading substring Address: from the cast wallet address command

println!("Address: {}", SimpleCast::to_checksum_address(&addr));
? The leading substring makes the command a little more painful to chain & seems unnecessary.

I haven't gotten far enough to see if there are other places this pattern exists.

@mattsse
Copy link
Member

mattsse commented Oct 12, 2022

makes sense, @appleseed-iii

feel free to open a PR

@PaulRBerg
Copy link
Contributor

Can we add table tests to this checklist?

I think that it's a very important feature that it's currently missing from Forge.

@ChainsightLabs
Copy link

Can we add table tests to this checklist?

I think that it's a very important feature that it's currently missing from Forge.

Yes, table tests please!

@dalechyn
Copy link

dalechyn commented Mar 4, 2023

What else are we missing?

Maybe a VS Code extension?

I was happy to learn about foundry.toml and put my remappings in there. It compiles and runs fine, but VS Code doesn't yet recognize the remappings (red triggering squiggles) and putting them in workspace settings doesn't feel great. I ended up moving back to remappings.txt temporarily.

Makes even more sense to make a separate Language Server, as there is only vscode-s one that cannot be even used in vim.

@y1cunhui
Copy link
Contributor

y1cunhui commented Mar 7, 2023

Hello, I'm wondering what does "Solidity Book using Foundry" means? I 'm interested in this topic and willing to finish this

@milaabl
Copy link

milaabl commented May 8, 2023

@y1cunhui , probably something like a Solidity development with Foundry guidelines book? Not sure

@ennioVisco
Copy link

foundryup runnable natively on Windows

@zerosnacks zerosnacks unpinned this issue Apr 8, 2024
@zerosnacks
Copy link
Member

Closing as open checkboxes have their individual follow-up tickets or are top of mind:

@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-meta Type: meta
Projects
Archived in project
Development

No branches or pull requests