Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PK pull not working nor being learned #7

Open
Ignaramico opened this issue Jun 8, 2020 · 2 comments
Open

PK pull not working nor being learned #7

Ignaramico opened this issue Jun 8, 2020 · 2 comments

Comments

@Ignaramico
Copy link

The "pk pull" spell is not able to be learned nor it works

for future references
{ "effect": "area_pull", "effect_targets": [ "item" ], },

while using the effect area_pull use "effect_filter" instead of effect_filter
source PR : CleverRaven/Cataclysm-DDA#31783

alternatives i have thought

Put another kind of spell in its place, that effect is lame, it doesnt affect monsters nor damage them

@dkargin
Copy link

dkargin commented Jul 30, 2020

I've implemented pull effect on creatures using knockback code. Maybe this code has changed in a last year, so I need to check it out again. All the damage was applied through knockback logic as well.

@foulman
Copy link
Owner

foulman commented Jul 31, 2020

I'll try and get on this, sorry, you know all our effort is going into Fantasy/XP/and MU right now! I do want to merge this in at some point though.
Also, @dkargin this may have just been something I screwed up, but do check it, and if you are willing to discuss it a bit, I think we could definitely suggest some minor changes and get a better understanding of it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants