Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#29 Map view dissappears in mobile view #34

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

pkspyder007
Copy link
Contributor

@pkspyder007 pkspyder007 commented Dec 24, 2019

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

https://summit2020.netlify.com/

Description / Changes

I changed the layout to proper row and column system. Then added some custom css and removed the static height for the container.

Screenshots if any:

Before:

Screenshot from 2019-12-24 23-11-29

After:

Screenshot from 2019-12-24 23-10-54


@mariobehling mariobehling merged commit 65e3a51 into fossasia:master Jan 5, 2020
@mariobehling
Copy link
Member

Unfortunately I did not check the view on the desktop at that time carefully enough. The issue results in a broken view on the desktop browers. Therefore reverting it.

@DawnArchi01
Copy link

@mariobehling I want to work on this , it would be really helpful if you can elaborate more on the same .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map view disappears in mobile view
3 participants