Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a alert dialog when files are empty #661

Closed
wants to merge 2 commits into from
Closed

added a alert dialog when files are empty #661

wants to merge 2 commits into from

Conversation

Mayank9mare
Copy link

Fixes #650

Chans: [ created a new alert dialog which is shown when the files are not present or their length is 0 ]

Added at line: 69 in ShareDataActivity

Copy link
Contributor

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't change gradle configurations in a PR fixing some other issue. Only address the parts related to the issue you're trying to solve.
  2. Follow the PR template that is given when opening a PR. No need to invent another.
  3. Please provide screenshots and APK files to test the feature. (If you followed the PR template, you wouldn't have missed that)
  4. Reformat the code. Lots of indent issues I can see here. (Once again, if you followed the PR template, you wouldn't have missed that)

@Mayank9mare Mayank9mare closed this Oct 7, 2020
@Mayank9mare Mayank9mare deleted the first branch October 7, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: To fix a NullPointerException in ShareDataActivity
2 participants