Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: App crash on entering large value for Bins #601

Open
dheerajkotwani opened this issue Jan 24, 2020 · 0 comments · May be fixed by #602
Open

bug: App crash on entering large value for Bins #601

dheerajkotwani opened this issue Jan 24, 2020 · 0 comments · May be fixed by #602

Comments

@dheerajkotwani
Copy link
Member

dheerajkotwani commented Jan 24, 2020

Describe the bug
App crash if we enter large values to Sample, bins or numbers in settings

Expected Behavior
App should not crash and accept the entered value

Steps to reproduce it
Open the settings in the app
Enter a value of more than 8 digits
App Crash

LogCat for the issue
E/AndroidRuntime: FATAL EXCEPTION: main Process: io.neurolab, PID: 3162 java.lang.NumberFormatException: For input string: "4454858874" at java.lang.Integer.parseInt(Integer.java:524) at java.lang.Integer.valueOf(Integer.java:611) at io.neurolab.fragments.NeuroSettingsFragment.onSharedPreferenceChanged(NeuroSettingsFragment.java:64) at android.app.SharedPreferencesImpl$EditorImpl.notifyListeners(SharedPreferencesImpl.java:479) at android.app.SharedPreferencesImpl$EditorImpl.apply(SharedPreferencesImpl.java:387) at android.support.v7.preference.Preference.tryCommit(Preference.java:1613) at android.support.v7.preference.Preference.persistString(Preference.java:1644) at android.support.v7.preference.EditTextPreference.setText(EditTextPreference.java:69) at com.takisoft.fix.support.v7.preference.EditTextPreference.setText(EditTextPreference.java:37) at com.takisoft.fix.support.v7.preference.EditTextPreferenceDialogFragmentCompat.onDialogClosed(EditTextPreferenceDialogFragmentCompat.java:90) at android.support.v7.preference.PreferenceDialogFragmentCompat.onDismiss(PreferenceDialogFragmentCompat.java:270) at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1337) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:165) at android.app.ActivityThread.main(ActivityThread.java:6375) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:802)

Screenshots of the issue
neuro_crash_bins

System Information

DeviceRedmi Note 4
Android version/OSNougat 7.0

Would you like to work on the issue?
Yes

@dheerajkotwani dheerajkotwani linked a pull request Jan 24, 2020 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant