Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding animation to the play pause buttons in the Meditate activity #586

Open
AkshobhyaP opened this issue Jan 19, 2020 · 7 comments
Open

Comments

@AkshobhyaP
Copy link
Member

Describe the bug
No animation is there when play or pause button are pressed.

Expected Behavior
A animation should be present to let the user know if the button is pressed.

Steps to reproduce it
Open meditate activity from main screen -> Press any play/pause button.

Screenshots of the issue
20200119_225611

System Information

DeviceOneplus 3
Android version/OSPie 9.0

Would you like to work on the issue?
YES

@AkshobhyaP
Copy link
Member Author

@adityastic @jddeep

@ho-dor
Copy link
Contributor

ho-dor commented Jan 20, 2020

What kind of animation are you planning @AkshobhyaP ?

@AkshobhyaP
Copy link
Member Author

AkshobhyaP commented Jan 20, 2020

I am thinking of using only a single button for play/pause which gave a ripple effect when pressed and icon changed from play to pause or vice-versa depending on the state. And adding a animation to restart button which rotates it image 360° to its original state with a ripple effect.

@dheerajkotwani
Copy link
Member

@AkshobhyaP are you working on this?

@AkshobhyaP
Copy link
Member Author

@dheerajkotwani I have fixed this issue and will make a pull request in the upcoming days.

@ho-dor
Copy link
Contributor

ho-dor commented Jan 26, 2020

@AkshobhyaP this feature might break since there is a issue with lifecycle handling in the player on which I am working. I will be creating a PR in a day pr two then u can make these changes after that.

@AkshobhyaP
Copy link
Member Author

@ho-dor I noticed that. I'll wait till you fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants