-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding animation to the play pause buttons in the Meditate activity #586
Comments
What kind of animation are you planning @AkshobhyaP ? |
I am thinking of using only a single button for play/pause which gave a ripple effect when pressed and icon changed from play to pause or vice-versa depending on the state. And adding a animation to restart button which rotates it image 360° to its original state with a ripple effect. |
@AkshobhyaP are you working on this? |
@dheerajkotwani I have fixed this issue and will make a pull request in the upcoming days. |
@AkshobhyaP this feature might break since there is a issue with lifecycle handling in the player on which I am working. I will be creating a PR in a day pr two then u can make these changes after that. |
@ho-dor I noticed that. I'll wait till you fix the issue. |
Describe the bug
No animation is there when play or pause button are pressed.
Expected Behavior
A animation should be present to let the user know if the button is pressed.
Steps to reproduce it
Open meditate activity from main screen -> Press any play/pause button.
Screenshots of the issue
System Information
Would you like to work on the issue?
YES
The text was updated successfully, but these errors were encountered: