Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit default fonts & standardize size if applicable. #460

Open
tropicandid opened this issue Jul 18, 2024 · 1 comment · Fixed by #461
Open

Audit default fonts & standardize size if applicable. #460

tropicandid opened this issue Jul 18, 2024 · 1 comment · Fixed by #461
Assignees

Comments

@tropicandid
Copy link
Contributor

tropicandid commented Jul 18, 2024

The goal of this ticket is to audit gesso-wp's font system as it stands and establish a standard (slightly more trim) for pre-defined sizes and families.

AC:

  • Reduce the amount of pre-defined fonts in the theme.json to a conventional baseline of seven different fonts OOTB
  • Rename them to follow the following convention:

xxx-small (14px)
xx-small
x-small
Small
Medium
Large
x-large
xx-large
xxx-large

The reason for changing our predefined fonts to the label and amount above is two fold:

  1. The names we define in theme.json are human readable in the CMS when people are managing their selected font site. Right now they just display numbers which can be a little confusing. The seven defined names above follow the WP Core convention and are a bit more human readable.
  2. We generally have more defined fonts than we have in a theme design. We know we will have a standard of 6 sizes for headers, as well as at least 1 additional size, leading to a baseline of 7 that we can add to as designs need more.

To determine what you feel is the best baseline for those sizes, please take a look at the WP 2024 theme to compare our current font sizes and families against what is being implemented by the core team: https://wordpress.org/themes/twentytwentyfour/ Their theme.json will provide a strong foundation to compare our slew of font size declarations against. You can also take a look at some of our more modern figma examples for what our in house convenstions have been as of late:

https://www.figma.com/design/53pTSftpSI6AUqaMqpPojN/Accelerator-(Gates-Foundation)?node-id=4679-6686&t=w8nu8xpgA0GT0eyo-0

Please reference the standard convention for min/max values for the fluid fonts within the 2024 theme. Their size is generally matching the max value. Please also do not apply a fluid font size that ranges below 14px for accessibility reasons.

@tropicandid tropicandid changed the title Audit default fonts & standardize size & families if applicable. Audit default fonts & standardize size if applicable. Jul 18, 2024
@tropicandid
Copy link
Contributor Author

PR for this has been approved and merged. Once we release RC to 5.x we will close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants