Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Sun Position in the sun position dialog does not match to sunrise and sunset. #844

Open
suntimer24 opened this issue Nov 17, 2024 · 3 comments
Labels

Comments

@suntimer24
Copy link

Describe the bug
Sunset begins when the top of the sun is rising over the horizon. Sunset begins when its bottom touches the horizon.
See screenshots.

Screenshots
001_-_Sunrise_Sun_position does not fit
002_-_Sunset_Sun_position does not fit

Version Info:

  • App Version: [0.16.3]
  • Android Version: [Android 11 (LineageOS 18.1)] (there are no longer new versions of LOS available for my device)
@suntimer24 suntimer24 changed the title Sun Position in the sun position dialog does not match to sunrise and sunset. [Bug] - Sun Position in the sun position dialog does not match to sunrise and sunset. Nov 17, 2024
@forrestguice

This comment was marked as outdated.

@forrestguice
Copy link
Owner

Actually... after looking closely at the screenshots, it seems I mistook this for a different problem.

Your screenshots show how you think time of sunrise/sunset should be displayed, is that correct? i.e. sunset is reported at 16:15, but in the graph its bottom touches the "horizon" at 15:59.

@forrestguice
Copy link
Owner

Sunset begins when its bottom touches the horizon.

Well... sunset occurs when its upper limb disappears below the horizon, so I think your second screenshot should actually be similar to your first (except mirrored). However...

I think the issue you are perceiving is that the circle isn't an accurate representation of the sun, especially as its edge moves over the "horizon" line on the graph. At the time of civil twilight, nautical twilight, etc, that circle is centered over the line (as expected). It makes sense (and is accurate) if you think of that circle as a point instead.

I guess this could be "fixed" by indicating the importance of the center, maybe by drawing a vertical line behind it (similar to the "crosshair" in the sunlight graph).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants