Skip to content

Commit cee8a20

Browse files
committed
fix(lift): prevent error when no dependencies are provided in results passed to lifter
1 parent f042029 commit cee8a20

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/lift/lift.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default async function ({projectRoot, vcs, results, pathWithinParent, enh
2222
const {
2323
scripts,
2424
tags,
25-
dependencies,
25+
dependencies: {javascript: dependencies} = {},
2626
packageManager: manager
2727
} = results;
2828

@@ -51,7 +51,7 @@ export default async function ({projectRoot, vcs, results, pathWithinParent, enh
5151

5252
await liftPackage(
5353
deepmerge.all([
54-
{projectRoot, scripts, tags, dependencies: dependencies.javascript, packageManager, vcs, pathWithinParent},
54+
{projectRoot, scripts, tags, dependencies, packageManager, vcs, pathWithinParent},
5555
enhancerResults
5656
])
5757
);

src/lift/lift.test.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,11 @@ describe('lift', () => {
3131
const tags = any.listOf(any.word);
3232
const javascriptDependencies = any.simpleObject();
3333
const dependencies = {...any.simpleObject(), javascript: javascriptDependencies};
34-
const devDependencies = any.listOf(any.word);
3534
const packageManager = any.word();
3635
const manager = any.word();
3736
const enhancerResults = any.simpleObject();
3837
const vcsDetails = any.simpleObject();
39-
const results = {...any.simpleObject(), scripts, tags, dependencies, devDependencies, packageManager: manager};
38+
const results = {...any.simpleObject(), scripts, tags, dependencies, packageManager: manager};
4039
const pathWithinParent = any.string();
4140
const packageDetails = any.simpleObject();
4241
const internalEnhancers = {
@@ -106,4 +105,10 @@ describe('lift', () => {
106105

107106
expect(liftResults).toEqual(enhancerResults);
108107
});
108+
109+
it('should not error when no dependencies are provided', async () => {
110+
core.applyEnhancers.mockResolvedValue(enhancerResults);
111+
112+
await lift({projectRoot, vcs: vcsDetails, results: any.simpleObject(), pathWithinParent});
113+
});
109114
});

0 commit comments

Comments
 (0)