Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GHA to test formulas? #86

Open
ronaldtse opened this issue Jan 22, 2021 · 3 comments
Open

Add GHA to test formulas? #86

ronaldtse opened this issue Jan 22, 2021 · 3 comments
Assignees
@alexeymorozov
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

Right now when submitting a formula there is no feedback on whether that formula actually works...
@ronaldtse
Copy link
Contributor Author

Only test the changed formulas? Or all formulas?

@ronaldtse ronaldtse added the enhancement New feature or request label Apr 4, 2022
@alexeymorozov
Copy link
Contributor

alexeymorozov commented Apr 4, 2022 •
edited
Loading

Currently it tests only changed formulas on each PR.

It's better to test all formulas once in a while, if there have already been issues with existing formulas (what kind of issues? may be it should include integration tests with other software it is used by).

@ronaldtse
Copy link
Contributor Author

Agree with testing all formulas once in a while, e.g. one every 2 weeks or a rotating collection per week since there are so many formulas.

If a formula is problematic, we should have the job automatically create a GitHub issue (https://github.com/marketplace/actions/create-an-issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeymorozov alexeymorozov

Labels
enhancement New feature or request
Projects
Fontist
Status: High priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronaldtse @alexeymorozov