Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #879
foam.preview.noteEmbedInContainer
content-card![[note-a]]
), and then have another regex that does the parsing and grouping to extract the modifier and the wikilink. This leads to a bit of messy regexes, but I added tests to try to confirm their validity.full-card![[note]]
would match both modifiers, whereascard-full![[note]]
wouldn't recognize thecard
portion and just parse thefull
part. 🫤 I could make it recognize both, but it would require expanding the existing regex, which could get ugly. Then again, the existing behavior might confuse users.Let me know if this is what you had in mind!
Testing
Given we have
content-inline
as the user settingCase 1: no type modifiers should just default to the user setting
Case 2: adding a type modifier
content
should not have an effect since it's already the defaultCase 3: adding one modifier
card
should overrideinline
resulting incard-inline
styleCase 4: adding two modifiers
full-card
should override both default style and scope resulting infull-card
style