Improved test cleanup and config management (#1274)

* clean up test workspace before running tests

* improved function that runs code with modified config to properly restore former value

Author: riccardoferretti

packages/foam-vscode/src/test/run-tests.ts

@@ -1,3 +1,4 @@
+import rf from 'rimraf';
 import path from 'path';
 import { runTests } from 'vscode-test';
 import { runUnit } from './suite-unit';
@@ -34,12 +35,21 @@ async function main() {
       // Passed to --extensionTestsPath
       const extensionTestsPath = path.join(__dirname, 'suite');
 
+      const testWorkspace = path.join(
+        extensionDevelopmentPath,
+        '.test-workspace'
+      );
+      // clean test workspace
+      rf.sync(path.join(testWorkspace, '*'));
+      rf.sync(path.join(testWorkspace, '.vscode'));
+      rf.sync(path.join(testWorkspace, '.foam'));
+
       // Download VS Code, unzip it and run the integration test
       await runTests({
         extensionDevelopmentPath,
         extensionTestsPath,
         launchArgs: [
-          path.join(extensionDevelopmentPath, '.test-workspace'),
+          testWorkspace,
           '--disable-extensions',
           '--disable-workspace-trust',
         ],

packages/foam-vscode/src/test/test-utils-vscode.ts

@@ -108,10 +108,10 @@ export const runCommand = async <T>(command: string, args: T = undefined) =>
  * @param fn the function to execute
  */
 export const withModifiedConfiguration = async (key, value, fn: () => void) => {
-  const old = vscode.workspace.getConfiguration().get(key);
+  const old = vscode.workspace.getConfiguration().inspect(key);
   await vscode.workspace.getConfiguration().update(key, value);
   await fn();
-  await vscode.workspace.getConfiguration().update(key, old);
+  await vscode.workspace.getConfiguration().update(key, old.workspaceValue);
 };
 
 /**