Skip to content

Conversation

@aniket2405
Copy link

@aniket2405 aniket2405 commented Jan 2, 2026

Tracking issue

Closes #6821

Why are the changes needed?

  • Test Script
    Added test/scripts/get_task_details.sh to allow for manual testing of the GetTaskDetails endpoint using buf curl.

What changes were proposed in this pull request?

How was this patch tested?

Endpoint Validation

The GetTaskDetails RPC endpoint is already tested in the existing TestDeployTask integration test which verifies:

  • Task details are retrieved successfully
  • Response contains correct taskId, metadata, and spec
=== RUN   TestDeployTask
time="2026-01-03T01:58:22+05:30" level=info msg="Created/Updated task: test-org/test-project/test-domain/test-task version 1767385702037607000"
    task_service_test.go:59: Task deployed successfully: org:"test-org" project:"test-project" domain:"test-domain" name:"test-task" version:"1767385702037607000"
    task_service_test.go:74: Task details retrieved successfully: task_id:{org:"test-org" project:"test-project" domain:"test-domain" name:"test-task" version:"1767385702037607000"} metadata:{short_name:"test-task" deployed_at:{seconds:1767385702 nanos:39008000}} spec:{task_template:{type:"container" container:{image:"alpine:latest" args:"echo" args:"hello"}}}

Script Validation

During development, validated the script works correctly by:

  1. Starting the test server locally through docker
  2. Running create_task.sh to deploy a test task
  3. Running get_task_details.sh to retrieve task details
  4. Confirmed the script returns complete task information in JSON format
{
  "details": {
    "taskId": {
      "org": "testorg",
      "project": "testproject",
      "domain": "development",
      "name": "my_task",
      "version": "1"
    },
    "metadata": {
      "shortName": "my_task",
      "deployedAt": "2026-01-02T20:47:48.309379Z"
    },
    "spec": {
      "taskTemplate": {
        "type": "python"
      }
    }
  }
}

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@aniket2405
Copy link
Author

@machichima The change is ready. Please have a look at this. Thanks!

@machichima
Copy link
Member

Hi @aniket2405 ,
Could you please add DCO? Thank you!

@aniket2405
Copy link
Author

Hi @machichima
I've updated the DCO. Thanks! Please have a look.

@machichima
Copy link
Member

machichima commented Jan 16, 2026

Could you please do git rm --cached gen/rust/Cargo.lock? We ignore the Cargo.lock in #6844 (comment)

After doing so the CI test should pass

@aniket2405
Copy link
Author

@machichima
Thanks for the review.
Removed the Cargo.lock file in accordance with #6844 (comment)
Hope the CI test passes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants