Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile and pipline should have pinned versions of dependencies #1269

Open
ilithanos opened this issue Mar 26, 2024 · 2 comments
Open

Makefile and pipline should have pinned versions of dependencies #1269

ilithanos opened this issue Mar 26, 2024 · 2 comments

Comments

@ilithanos
Copy link
Collaborator

kubernetes-sigs/controller-runtime#2720

I ran into this breaking our test CI pipelines because of setup-testenv being set to @latest rather than a pinned version. This results in the pipelines breaking due to it updating to a version that needs a newer go version that we currently use.

I've currently pinned the version to version 16, but we need to update at some point in the future.

This issue is also ment as a reminder to not use @latest in general, but use specific pinned versions to ensure consistant builds across runs.

@chanwit
Copy link
Collaborator

chanwit commented Mar 29, 2024

oh yes a recent PR ran into this issue too. Thank you for bringing this up.

@ilithanos
Copy link
Collaborator Author

ilithanos commented Mar 29, 2024

@chanwit I basically fixed the case creating that issue as part of the helm chart PR, so it should be fixed in main now.

I would like to leave this issue open until I've had a chance to check if there are any other places without pinned versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants