Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture case-study code to CI #11441

Open
1 of 3 tasks
ericwindmill opened this issue Nov 26, 2024 · 1 comment
Open
1 of 3 tasks

Add architecture case-study code to CI #11441

ericwindmill opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
e2-days Effort: < 5 days fix.code-sample Needs new or updated code sample p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@ericwindmill
Copy link
Contributor

ericwindmill commented Nov 26, 2024

Page URL

docs.flutter.dev/app-architecture/case-study

Page source

No response

Describe the problem

Right now, the code snippets in the PR #11414 aren't under CI. To add them to CI and test them properly, each snippet would require a lot of context.
The code those snippets are copied from lives in flutter/samples. Given that the apps primary purpose is to back the documentation, I'd like to move the entire app from flutter/samples to this repository rather than fake the needed context in new snippets.

Expected fix

  • Move the app from flutter/samples to a new subdir in flutter/website/examples
  • Use docregions to add the snippets to CI

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@ericwindmill ericwindmill added p2-medium Necessary but not urgent concern. Resolve when possible. e2-days Effort: < 5 days fix.code-sample Needs new or updated code sample labels Nov 26, 2024
@ericwindmill ericwindmill self-assigned this Nov 26, 2024
@ericwindmill ericwindmill changed the title Migrate compass_app from flutter/samples to flutter/website Add architecture case-study code to CI Nov 26, 2024
@ericwindmill
Copy link
Contributor Author

Belongs to #11374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2-days Effort: < 5 days fix.code-sample Needs new or updated code sample p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Development

No branches or pull requests

1 participant