Merge pull request #23 from readdle/feature/tslint-support

Add tslint and fix all warnings

Author: endway

decorators/directive/index.ts

@@ -41,5 +41,5 @@ export function Directive<IComponentClass>({selector}: {
         Reflect.defineMetadata(Metakeys.type, DeclarationType.directive, target);
 
         return target;
-    }
+    };
 }

decorators/ng-module/index.ts

@@ -1,15 +1,19 @@
 import importHandler from "./metadata-handlers/import";
 import daclarationHandler from "./metadata-handlers/declaration";
 import providerHandler from "./metadata-handlers/provider";
-import counter from '../../helpers/counter';
+import counter from "../../helpers/counter";
 
 export function NgModule({id, imports, declarations, providers, directRegister}: any) {
     return function (target: any) {
-        var ng1ModuleIds: Array<string> = [];
-        var ng1RouterConfig;
+        let ng1ModuleIds: Array<string> = [];
+        let ng1RouterConfig;
 
-        if (imports && imports.length) {
-            var {ng1ModuleIds, ng1RouterConfig} = importHandler(imports);
+        const hasImports = imports && imports.length;
+
+        if (hasImports) {
+            const handledImports = importHandler(imports);
+            ng1ModuleIds = handledImports.ng1ModuleIds;
+            ng1RouterConfig = handledImports.ng1RouterConfig;
         }
 
         target.ng1ShiftModuleName = `${target.name}-${counter("moduleName")}`;
@@ -35,5 +39,5 @@ export function NgModule({id, imports, declarations, providers, directRegister}:
         if (directRegister) {
             directRegister(ng1Module);
         }
-    }
+    };
 }

decorators/ng-module/metadata-handlers/import.ts

@@ -30,5 +30,5 @@ export default function importHandler(imports: Array<ng1Module>) {
     return {
         ng1ModuleIds,
         ng1RouterConfig
-    }
+    };
 }

helpers/array.ts

@@ -1,6 +1,6 @@
 export function findFirst<T>(array: Array<T>, expression: (value: T) => boolean): T {
     if (!angular.isFunction(expression)) {
-        let first = array[0];
+        const first = array[0];
         if (!first) {
             return null;
         }

helpers/counter.ts

@@ -1,11 +1,11 @@
-let store = {} as any;
+const entityCounters: Record<string, number> = {};
 
 export default function counter(entity: string) {
-    const registeredEntity = entity in store;
+    const registeredEntity = entity in entityCounters;
 
     if (!registeredEntity) {
-        store[entity] = 0;
+        entityCounters[entity] = 0;
     }
 
-    return store[entity]++;
+    return entityCounters[entity]++;
 }

helpers/kebab-case-to-camel-case.ts

@@ -1,8 +1,9 @@
 export default function kebabCaseToCamelCase(str: string) {
     if (str.indexOf("-") !== -1) {
-        const newArr = str.split("-");
+        const newArr = str.toLowerCase().split("-");
 
-        for (var i = 1 ; i < newArr.length ; i++) {
+        // We are starting from 1 because the first letter in camelCase word is in lowercase
+        for (let i = 1; i < newArr.length; i++) {
             newArr[i] = newArr[i].charAt(0).toUpperCase() + newArr[i].substr(1);
         }
 

index.ts

@@ -83,7 +83,7 @@ export function Inject(dependencyName: string): ParameterDecorator {
     };
 }
 
-export function Component<IComponentClass>(config?: {selector?: string, template?: string}): ClassDecorator {
+export function Component(config?: {selector?: string, template?: string}): ClassDecorator {
     return function (target: any) {
         if (config) {
             if (config.template) {
@@ -118,7 +118,7 @@ export function Component<IComponentClass>(config?: {selector?: string, template
         Reflect.defineMetadata(Metakeys.type, DeclarationType.component, target);
 
         return target;
-    }
+    };
 }
 
 export class EventEmitter {