You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Been using this lib for a little bit now and have found that having a CommandSender need to provide its groups and handle its hasPermission is a little cumbersome and doesn't make sense. CommandSender simply sends a command.
At most I'd say CommandSender needs only the hasPermission and that's it.
The thing is: if (as developer using this library) I'm handling some action that a CommandSender (or any other PermissionSubject) is trying to do, I might want to know what are his groups (eg. so that I put a group prefix in his chat message), and I don't feel like figuring out what object is responible for this so that I can ask him.
The way it is done right now, the CommandSender can easily delegate these methods to some other object, while allowing easy creation of allmighty CommandSenders (eg. ConsoleCommandSender or ScheduledJobCommandSender who have all permissions).
lukespragg
changed the title
Seperate out permission/groups from CommandSender
Separate out permission/groups from CommandSender
Aug 12, 2014
Been using this lib for a little bit now and have found that having a CommandSender need to provide its groups and handle its hasPermission is a little cumbersome and doesn't make sense. CommandSender simply sends a command.
At most I'd say CommandSender needs only the hasPermission and that's it.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: