Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication returned to user when message was not posted #69

Open
devkev opened this issue Sep 21, 2015 · 0 comments
Open

No indication returned to user when message was not posted #69

devkev opened this issue Sep 21, 2015 · 0 comments

Comments

@devkev
Copy link

devkev commented Sep 21, 2015

When oulu is unable to successfully post a message to the Flowdock API, it records the error in its logs. However, it does not inform the user that the message was not delivered. This means that when the API is having trouble receiving messages (like last Friday), IRC users have no way of knowing which (if any) of their messages have actually been sent.

This very severely impacts the usability of the IRC gateway, since there is no way to trust that it has actually delivered any messages - and no way to check, apart from using the web interface or a native client (and avoiding these is usually the point of using the IRC gateway in the first place).

The problem is on line 290 and line 297 of irc_connection.rb. This is where $logger.error is called, but what is almost certainly needed is something like

send_reply(render_unavailable_resource)

or

send_reply(render_cannot_send_to_channel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant