Sync takes longer since v5.8.3

[ricklahaye]

Which version of floccus are you using?

5.8.3

How many bookmarks do you have, roughly?

30

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Git

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Orion 1.4.4

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Floccus 5.8.3 has issues with syncing and stays stuck on 'Sychronization in progress'. Sometimes it does sync succesfully but it can take multiple minutes!

This behaviour is occuring for Git, but also WebDav integration.

Floccus 5.8.2 syncs correctly and finishes within 1-3 seconds.

Expected Behavior

Syncing should finish in few seconds instead of minutes.

To Reproduce

Install Floccus 5.8.3, add profile, and notice that syncthing takes multiple minutes or does not sync at all.
Installl Floccus 5.8.2, and notice that syncing finishes correctly in few seconds.

Debug log provided

• I have provided a debug log file

[github-actions]

Hello! 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. Let me give you a short introduction on what to expect from this issue tracker to avoid misunderstandings. I'm Marcel. I created floccus a few years ago, and have been maintaining it since. I currently work for Nextcloud which leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. It helps when you stick around to answer follow up questions I may have, as very few bugs can be fixed directly from the first bug report, without any interaction. If information is missing in your bug report and the issue cannot be solved without it, I will have to close the issue after a while. Note also that GitHub in general is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! If you cannot lend a helping hand, to continue the development and maintenance of this project in a sustainable way, I ask that you donate to the project when opening an issue (or at least once your issue is solved), if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself.

Thank you for reading through this primer. I look forward to working with you on this issue! Cheers! 💙

[marcelklehr]

Hi @ricklahaye
Thank you for taking the time to give feedback by opening this issue! I'll try to reproduce this and fix it. I have a hunch that this has to do with the optimization I did for the Chrome issue where Chrome was killing the floccus worker due to too long macro tasks in the event loop, now there are smaller macro tasks, but maybe they are too small and are causing an overhead..

[ricklahaye]

Hi @ricklahaye Thank you for taking the time to give feedback by opening this issue! I'll try to reproduce this and fix it. I have a hunch that this has to do with the optimization I did for the Chrome issue where Chrome was killing the floccus worker due to too long macro tasks in the event loop, now there are smaller macro tasks, but maybe they are too small and are causing an overhead..

Thank you. I have another debug log. Weirdly enough the log shows it took a total of 5 seconds. I am very sure that the UI showed sync in progress for way longer than 5 seconds. Seems that the timing in the log is of?

[ricklahaye]

Hi @ricklahaye Thank you for taking the time to give feedback by opening this issue! I'll try to reproduce this and fix it. I have a hunch that this has to do with the optimization I did for the Chrome issue where Chrome was killing the floccus worker due to too long macro tasks in the event loop, now there are smaller macro tasks, but maybe they are too small and are causing an overhead..

Thank you. I have another debug log. Weirdly enough the log shows it took a total of 5 seconds. I am very sure that the UI showed sync in progress for way longer than 5 seconds. Seems that the timing in the log is of?

With another run today it took around 50 seconds for a sync to complete. The log however shows 5 seconds total again.

[marcelklehr]

I can reproduce that sync seems to take longer now.

I am very sure that the UI showed sync in progress for way longer than 5 seconds.

Where do you check in the UI? Do you check the Icon or the drop down overview panel?

[ricklahaye]

I can reproduce that sync seems to take longer now.

I am very sure that the UI showed sync in progress for way longer than 5 seconds.

Where do you check in the UI? Do you check the Icon or the drop down overview panel?

I check the status in the blue box in this overview (which I expectt to be drop down overview panel):

[SkyBlueHH]

With version 5.8.6, the problem seems to have been solved for most browsers.

However, in my Chromium (unfortunately an older one, on older mac OS), the problem persists in a slightly modified form: after startup, floccus starts synchronizing and the icon changes accordingly.

Unfortunately, the sync never finishes – until I click on the icon and the panel opens. From then on, it only takes the usual few seconds.