Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for percentage of actors enablement per type #386

Closed
jnunemaker opened this issue Nov 24, 2018 · 1 comment
Closed

Allow for percentage of actors enablement per type #386

jnunemaker opened this issue Nov 24, 2018 · 1 comment
Labels

Comments

@jnunemaker
Copy link
Collaborator

Right now percentage of actors is shared across all types that are checked. This is easiest to understand with a use case. Let's say you want to check if something is enabled by user and by some other type (say project, organization, repository, etc.). Currently, if you set % of actors to 20, that means 20% of users and projects (or any other type) would all be enabled.

It would be neat to be able to users for 20% and not enable % of actors for other types or any other number of combinations. I have no idea how I want to do this yet, but I want to at least track it as an issue so if others hit this they have a place to voice for or against or even start hacking.

The big thing is we'd need adapter storage for options or some other sort of meta data per feature (or gate value). #163 would make storage easy if I finally pull the trigger on that.

We'll also need a standard way to deserialize flipper_id's into type/id. Currently people seem to use colon or semicolon, but likely we'll need an actual serializer/deserializer with a default of semicolon and then allow people to use a custom serializer if they need different.

@jnunemaker
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant