-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we rename Fleet SDK to something with ergo in its name? #31
Comments
Fleet is such a cool name, maybe something like Fleet JS SDK? |
w3erg.js would be nice |
i like fleet but if you're going to change it to something incorporate dapp dappSDK.js |
If we are going to rename it, batter to have erg/ergo in its name.
I like this one too. |
Agreed IMO something like
Not a fan of abbreviating to "w3", IMO it's too close to "w3c" which is also sometimes just called w3 |
If fleet gets renamed then so should appkit. If appkit name does not change then what about appkit-js? If appkit changes then maybe something like ergosdk and ergosdk-js. |
First of all, I don't think the name is such a big problem. The greater problem is existence of ergo-js and ergo-ts. They should redirect to Fleet ideally. Appkit actually already called So, if do renaming, I suggest From design perspective, Appkit is dApp facing Java/Kotlin library on top of Sigma. Other issues:
|
Reiterating my comments from the chat below and adding some further discussion Would be good to have them all using the same naming if that’s logical. Something like
Yeah appreciate the difficulties in orchestrating a wider change, but it might be our best shot at doing so before the ecosystem matures any further. Certainly FleetSharp would need to rename in either case. But would be ideal if we could either change sigma-rust and Appkit too, or alternatively, rename Fleet to match one of them to make it a bit more cohesive.
I would've assumed they have a similar level of functionality personally but don't have a good grasp on the significance of this. But isn't that something we should be aiming for anyway?
|
@glasgowm148 @capt-nemo429 Sigma-rust, as the name suggests, is a port of Sigma, not Appkit. Thus it is on the core level and is wrapped in JS library (like Fleet) |
Certainly willing to change the FleetSharp name. I agree we might do good with some better names. |
Please do not rename. When learning a new technology and searching for libraries the cognitive context load is already pretty high. Personally i found it very confusing and overwhelming at the start of my journey that almost anything had either sigma or ergo in it's name. When everything has the same prefix, the prefix becomes meaningless. I hope other developers will follow fleet's example. |
I agree with nemos original sentiment but also not sure if it's worth prioritising. Cool to see so many people care about package naming 🤗 For me it comes down to what we want fleet to be, an AppKit/Sigma.js library vs a JavaScript library for Ergo. Edit: Talked to nemo, it appears the intent behind using Sigma.JS is mostly in testing envs not frontend dapps which means the bundle size matters way less, but keeping this here anyway: In regards to fleet being a Sigma.js library - have we ensured this is a valid path to take? I ask this because the I personally feel fleet could be something more than a JavaScript appkit, there's other popular library functionality that it could provide that aren't relevant outside the browser like react hooks/wallet connector/etc. Following web3 naming conventions would be great for this. "Appkit" makes the library familiar to people already in Ergo whereas web3 naming makes it discoverable by devs from other ecosystems |
I'm glad to see you guys care about Fleet SDK and really appreciate your feed back.
I like how
Good point!
Yeah, that makes me think. Indeed, the real problem is the existence of outdated/unsecure libraries not the name. Unfortunately we can't do much about that.
Excellent point, I agree that prefixes become meaningless if everything is ergo or sigma prefixed, but we have something very important here, all of them refers to ergo somehow thus creating a clear semantic connection. If I'm a newcomer and I see a lib called Fleet, the first thing that will come to my ming is that is some kind of fleet management library and probably not worths exploring, generating even more confusion, but if I find something called ergo-ts, my first impression will be different. See my point?
Definitively something that worths exploring, make the framework popular and don't worry about naming 🤔. Personally, I'm between @ross-weir's and @c8e4's suggestions. But always open to discussions. |
I believe Sigma.JS must be used where it shines: compiler, wallet, interpreter, and so on, on the back-end side. Furthermore, bundle size can be improved a lot once it's stable, from ~11mb to ~2mb, it's far from ideal for front-end usage but can be usable for some edge cases if necessary. Bundle size is a big concern to Front-end devs and it IS a real concern IMO. Having to load megabytes of code to do something simple as building a transaction or parsing a constant, is a no-go for most of them. Package Structure
Naturally, there are some edge cases, if one needs to parse a box that contains an ErgoTree v0 or work with AVL Trees, for example, Fleet's serializer will not be able to handle that, luckily we have Sigma.JS and sigma-rust to the rescue. |
Maybe a third option: keep the name as it is but make like a |
Honestly, I don't think the name is of much issue. A priority should be getting more documentation! |
Agree with this. A new dev probably googles ergo crypto JavaScript/typescript library/SDK/development It's possible more documentation under a domain (docusaurus maybe?) solves both problems as SEO will work for this. |
@capt-nemo429 @ross-weir |
@ross-weir @capt-nemo429 Example, ErgoNode has tons of potential optimisations still, even though many has been done, but, most of the done optimisations was observable bottlenecks first, and only then they was optimised away. Another example, MrStahlfelge had ZERO issues with crypto, serialisers, signing, interpretation, TX building etc, because he reused Sigma code entirely. Could we have lower app size? I'm sure similar solution can solve any latency problems in the frontend due to a large library size, just warm up the code in advance. |
I like the idea of a unified name for SDKs, but OTOH, what name should sigma-rust JS bindings have? "ErgoKit Rust JS" looks weird. |
It looks like the name is not that big of an issue, I would like to say thank you for the insights and amazing discussions. :) Let's keep it as Fleet and work on better documentation/branding. |
thrown a hint earlier but could give a look at (https://docusaurus.io/showcase) for quick scaffolding maybe? @capt-nemo429 (https://www.npmjs.com/package/docusaurus-plugin-typedoc) (https://github.com/tgreyuk/typedoc-plugin-markdown) (https://docusaurus.io/feature-requests/p/add-typedoc-api-support) possible alternatives: docsify, |
In short, I think Fleet is a great name, but it does not reflect the specific purpose of our Ergo SDK. Should we rename it?
Fleet is a catchy name that fits well in the Nautilus narrative, but it may cause confusion for newcomers. We often see them choosing outdated and unsafe libraries like
ergo-ts
andergo-js
over actively maintained ones like AppKit, sigma-rust, or Fleet.I believe this is partly due to the naming. The tooling name should clearly indicate its purpose and scope. Therefore, I would like to hear your opinion on renaming Fleet to something that includes Ergo/ERG in its name.
Some possible alternatives are:
v1.0 is quite close and that will represent breaking changes for implementors, so if we are going to rename it, a major release is a good opportunity for it.
I would love to know your opinions and suggestions on this proposal.
The text was updated successfully, but these errors were encountered: