Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Launcher portal fails to install when ~/.local/share/applications/ does not exist yet #1583

Closed
IlyaBizyaev opened this issue Jan 18, 2025 · 2 comments · Fixed by #1596
Closed

Dynamic Launcher portal fails to install when ~/.local/share/applications/ does not exist yet #1583

IlyaBizyaev opened this issue Jan 18, 2025 · 2 comments · Fixed by #1596
Labels
bug

Comments

@IlyaBizyaev
Copy link

Operating System

Fedora KDE 41

XDG Desktop Portal version

1.18

XDG Desktop Portal version (Other)

No response

Desktop Environment

KDE

Desktop Environment (Other)

No response

Expected Behavior

~/.local/share/applications/ is created if it does not exist yet (e.g., on a newly installed system)

Current Behavior

An error is returned by the Install method when it fails to create a symlink in a non-existent directory

(tested with https://flathub.org/apps/com.belmoussaoui.ashpd.demo)

Steps to Reproduce

  1. Ensure that there is no ~/.local/share/applications/
  2. Install and launch ASHPD Demo
  3. From the "Dynamic Launcher" page, select /usr/share/icons/Adwaita/16x16/devices/audio-headphones.png as the icon and click "Install"

Anything else we should know?

xdg-desktop-portal/src/dynamic-launcher.c

Line 278 in 736002f

if (!g_file_make_symbolic_link (link_file, relative_path, NULL, error))

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 18, 2025
swick added a commit to swick/xdg-desktop-portal that referenced this issue Jan 21, 2025
@swick
dynamic-launcher: Ensure $XDG_DATA_HOME/applications exists
50b3510 
It is possible that the directory has not been created by anything else
before which would make dynamic launcher creation fail.

Resolves: flatpak#1583
@swick swick mentioned this issue Jan 21, 2025
Merged
@swick
Copy link
Contributor

swick commented Jan 21, 2025

Could you try #1596?

@IlyaBizyaev
Copy link
Author

Yep, this fixes it :)

swick added a commit to swick/xdg-desktop-portal that referenced this issue Jan 26, 2025
@swick
dynamic-launcher: Ensure $XDG_DATA_HOME/applications exists
ea79fa7 
It is possible that the directory has not been created by anything else
before which would make dynamic launcher creation fail.

Resolves: flatpak#1583
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@swick @GeorgesStavracas
dynamic-launcher: Ensure $XDG_DATA_HOME/applications exists
7511ae7 
It is possible that the directory has not been created by anything else
before which would make dynamic launcher creation fail.

Resolves: #1583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
No open projects
Triage
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dynamic-launcher: Ensure $XDG_DATA_HOME/applications exists swick/xdg-desktop-portal
2 participants
@swick @IlyaBizyaev