Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant parameter in SaveFiles() method from FileChooser portal #22

Open
grulja opened this issue Feb 7, 2020 · 2 comments
Open

Redundant parameter in SaveFiles() method from FileChooser portal #22

grulja opened this issue Feb 7, 2020 · 2 comments

Comments

@grulja
Copy link
Contributor

grulja commented Feb 7, 2020

In xdp_portal_save_files() users might pass current_name parameter, but this one is not mentioned in xdg-desktop-portal documentation and doesn't seem to make sense in this call as you are saving multiple files at once.

@grulja
Copy link
Contributor Author

grulja commented Feb 11, 2020

This probably cannot be solved (removed) at this moment as it would break API for those using it already. On the other hand I don't expect many apps using it yet, especially the xdp_portal_save_files() function so perhaps it's safe to remove it in this early stage? It probably won't cause any harm having it there, it's just it might be confusing for someone.

@hadess
Copy link
Contributor

hadess commented Mar 26, 2020

@mjog wrote the SaveFiles functionality IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants