Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_CN and zh_TW translations are unused #4231

Closed
ovari opened this issue Dec 1, 2024 · 3 comments · Fixed by #4248
Closed

zh_CN and zh_TW translations are unused #4231

ovari opened this issue Dec 1, 2024 · 3 comments · Fixed by #4248

Comments

@ovari
Copy link
Contributor

ovari commented Dec 1, 2024

https://flathub.org/zh-Hans/apps/org.moneymanagerex.MMEX
https://flathub.org/zh-Hant/apps/org.moneymanagerex.MMEX

image

Catalogue data:

<name xml:lang="zh_CN">MMEX资金经理</name>
<name xml:lang="zh_TW">MMEX資金經理</name>
<summary xml:lang="zh_CN">组织财务并跟踪现金流</summary>
<summary xml:lang="zh_TW">組織財務並跟踪現金流</summary>

Thank you

@razzeee
Copy link
Member

razzeee commented Dec 2, 2024

Seems to be fine?

@bbhtt
Copy link
Contributor

bbhtt commented Dec 2, 2024

No, the translations for zh_CN and TW are present but the Hans and Hant pages are not using them for captions and summary.

See
https://flathub.org/zh-Hans/apps/org.moneymanagerex.MMEX

Either these two should be mapped to Hans and Hant or there should be a separate page for it.

@bbhtt bbhtt changed the title Looks like the locales are not mapped correctly zh_CN and zh_TW translations are unused Dec 2, 2024
@bbhtt
Copy link
Contributor

bbhtt commented Dec 2, 2024

Effectively zh_Hans and zh_CN are equivalent although the more correct form would be zh_Hans_CN. eg. gnulib considers them equivalent.

Hans and Hant are also currently less used in our catalogue, which means most of the zh translations are not getting used on the website.

→ grep -r "lang=\"zh_CN\"" flathub-stable-appstream.xml|wc -l
1068
→ grep -r "lang=\"zh_TW\"" flathub-stable-appstream.xml|wc -l
602
→ grep -r "lang=\"zh_Hans\"" flathub-stable-appstream.xml|wc -l
91
→ grep -r "lang=\"zh_Hant\"" flathub-stable-appstream.xml|wc -l
50

razzeee added a commit to razzeee/website that referenced this issue Dec 3, 2024
@razzeee razzeee closed this as completed in c2e373b Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants