Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a switch for Wayland #22

Open
ghost opened this issue Feb 6, 2024 · 6 comments
Open

Adding a switch for Wayland #22

ghost opened this issue Feb 6, 2024 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 6, 2024

Continuing from flathub/com.vscodium.codium#295
I would like to discuss the details of implementing support for Wayland here.

@sr66139p
Copy link

I came here from that same issue. Wayland works perfectly fine for me when running this command: flatpak run com.vscodium.codium --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland, but it is annoying using the terminal every time and if you disable X11 in flatseal, even if you enable fallback X11, no window will pop up. It seems like the only work that needs to be done for Wayland is to have it come enabled by default (with Wayland window decorations).
Unfortunately, it's not as easy as just adding the arguments to the desktop file as this breaks VSCodium on Xorg. I remember that VSCodium used to open in a Wayland native window at some point last year, but it lacked window decorations (at least on Gnome flathub/com.vscodium.codium#221) and had mouse cursor scaling issues. Now that the Chromium embedded framework/Electron have better Wayland support, we might be able to just re implement whatever allowed us to open a Wayland native window last year, and we would just have to figure out how to have Wayland window decorations enabled by default.

@noonsleeper
Copy link
Contributor

@larina3315 & @sr66139p I'm currently working to support wayland on a clean way

@noonsleeper
Copy link
Contributor

Well @larina3315 & @sr66139p I found that the latest build of codium doesn't complain about the --enable-features=WaylandWindowDecorations arg when you start on X11 like in the past, then we don't need to modify this wrapper at all.

@sr66139p
Copy link

I forgot to mention this before, but the latest version of the VSCodium Flatpak works perfectly in my Wayland session since the last update, and I made sure everything is Flatseal was set to default. Title bars (both native and custom), cursors, and everything everything else works. Thanks for the good work @noonsleeper

@noonsleeper
Copy link
Contributor

I forgot to mention this before, but the latest version of the VSCodium Flatpak works perfectly in my Wayland session since the last update, and I made sure everything is Flatseal was set to default. Title bars (both native and custom), cursors, and everything everything else works. Thanks for the good work @noonsleeper

You are welcome! 😄

@Bammede
Copy link

Bammede commented Sep 2, 2024

VSCodium do not work on my Fedora Silverblue Wayland, but X11 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants