Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fivetran_connector_schema_config #384

Open
pguinard-public-com opened this issue Dec 31, 2024 · 3 comments
Open

Import fivetran_connector_schema_config #384

pguinard-public-com opened this issue Dec 31, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@pguinard-public-com
Copy link

Is your feature request related to a problem? Please describe.
When working with connectors the terraform import blocks are very helpful to see a set of changes. fivetran_connector_schema_config does not support importing with a not on the provider of "You don't need to import this resource as it is synthetic (doesn't create new instances in upstream)."

Describe the solution you'd like
fivetran_connector_schema_config should be able to be imported into the existing terraform state to preview changes before blindly applying

Describe the use-cases if possible
When importing changes I want to see a terraform plan with no changes to know that I am not going to break my production environment.

Additional context

@nbaju1
Copy link

nbaju1 commented Jan 8, 2025

What will this show that running terraform plan won't?

@pguinard-public-com
Copy link
Author

Without having the ability to import an existing schemas running terraform plan will only update the existing schema overwriting the configuration. The goal is to be able to view an existing schema during import so that the terraform plan shows that desired_column. Perhaps I'm just confused by the documentation missing the import command https://registry.terraform.io/providers/fivetran/fivetran/latest/docs/resources/connector_schema_config#import

  # fivetran_connector_schema_config.example will be imported and updated in-place
   ~ resource "fivetran_connector_schema_config" "example" {
   ~ connector_id = "example"
     schemas = {
    "schema_name" = {
      tables = {
        "table_name" = {
          columns = {
            "hashed_column_name" = {
              hashed = true
            }
-            "desired_column" = {
-              hashed = true
-            }
            "blocked_column_name" = {
              enabled = false
            }
          }
        }
        "blocked_table_name" = {
          enabled = false
        }
      }
    }
    "blocked_schema" = {
      enabled = false
    }
  }

@nbaju1
Copy link

nbaju1 commented Jan 9, 2025

I misunderstood you initially. Agree, this would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants