Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Account for new category field in Hubspot models, bring in engagement table and update upstream joins #10

Closed
2 of 4 tasks
fivetran-avinash opened this issue Nov 8, 2024 · 0 comments · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@fivetran-avinash
Copy link
Contributor

fivetran-avinash commented Nov 8, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

A new category field was introduced in a recent PR to dbt_hubspot_source. More information available in these release notes.

We will need to add the category field to these models:

  • stg_hubspot__engagement_company
  • stg_hubspot__engagement_contact
  • stg_hubspot__engagement_deal

We will also need to account for category in the upstream join in the int_rag_hubspot__deal_document here to ensure uniqueness within the Hubspot ticket RAG.

How would you implement this feature?

We will bring in the engagement source table into the Hubspot model, add it at the staging layer, then join it in to ensure uniqueness of the Hubspot RAG data.

Follow the steps in this PR!, then validate uniqueness on the new Hubspot staging models and make sure the joins also reflect uniqueness.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

@fivetran-avinash fivetran-avinash changed the title [Feature] Add new category field to Hubspot staging models [Feature] Add new category logic to Hubspol models Nov 12, 2024
@fivetran-avinash fivetran-avinash changed the title [Feature] Add new category logic to Hubspol models [Bug] Account for new category logic in Hubspol models Nov 12, 2024
@fivetran-avinash fivetran-avinash changed the title [Bug] Account for new category logic in Hubspol models [Bug] Account for new category logic in Hubspot models Nov 12, 2024
@fivetran-avinash fivetran-avinash changed the title [Bug] Account for new category logic in Hubspot models [Bug] Account for new category logic in Hubspot models Nov 12, 2024
@fivetran-avinash fivetran-avinash changed the title [Bug] Account for new category logic in Hubspot models [Bug] Account for new category field in Hubspot models, update Hubspot rag Nov 12, 2024
@fivetran-avinash fivetran-avinash changed the title [Bug] Account for new category field in Hubspot models, update Hubspot rag [Bug] Account for new category field in Hubspot models, bring in engagement table and update upstream joins Nov 12, 2024
@fivetran-avinash fivetran-avinash added the bug Something isn't working label Nov 12, 2024
@fivetran-reneeli fivetran-reneeli self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants