Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add disabling models for non-existent sources #14

Open
3 of 4 tasks
kirk-dave opened this issue Aug 25, 2022 · 1 comment
Open
3 of 4 tasks

[Feature] Add disabling models for non-existent sources #14

kirk-dave opened this issue Aug 25, 2022 · 1 comment
Labels
priority:p3 Affects many users; can wait status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@kirk-dave
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

We (Dave.com) launch campaigns on Snapchat, but do no use creative url tags. This causes this package to fail (see below) since the creative_url_tag_history table does not exist in the schema managed by the Snapchat connector.

Please add a config to disable models for non-existent sources (specifically creative_url_tag_history). For example, the Fivetran Stripe package has this currently:

Screen Shot 2022-08-25 at 10 24 56 AM


14:33:03  Database Error in model stg_snapchat__creative_url_tag_history_tmp (models/tmp/stg_snapchat__creative_url_tag_history_tmp.sql)
14:33:03    002003 (42S02): SQL compilation error:
14:33:03    Object 'MARKETING_DB.SNAPCHAT_ADS_V2.CREATIVE_URL_TAG_HISTORY' does not exist or not authorized.
14:33:03    compiled SQL at target/run/snapchat_ads_source/models/tmp/stg_snapchat__creative_url_tag_history_tmp.sql
14:33:03  Encountered an error:
FailFast Error in model stg_snapchat__creative_url_tag_history_tmp (models/tmp/stg_snapchat__creative_url_tag_history_tmp.sql)
Failing early due to test failure or runtime error
Error: Process completed with exit code 2.

Describe alternatives you've considered

Have worked w. our Fivetran AE & support to find alternatives. They recommended requesting this feature.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@kirk-dave kirk-dave added the enhancement New feature or request label Aug 25, 2022
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @kirkbrunson-dave thanks so much for opening this ticket and my apologies that it has taken our team longer than expected to look into this ticket.

I believe this is a doable feature request and I could see others benefiting from the ability to disable the url tag source if they are not using it. In addition to disabling the models within the staging package, we would also want to disable its downstream uses. It seems the main use is within our creative prep intermediate model. Disabling the linked CTE shouldn't be too much of a lift or cause issues for others.

Our team will scope this out further and plan to bring the update into a future sprint. We will post back here with more details once we start working on the feature.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement priority:p3 Affects many users; can wait status:accepted Scoped and accepted into queue update_type:feature Primary focus is to add new functionality and removed enhancement New feature or request labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Affects many users; can wait status:accepted Scoped and accepted into queue type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

No branches or pull requests

2 participants