From 02a89a1d07cc0a3210309a34c2c10158e181e43d Mon Sep 17 00:00:00 2001 From: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> Date: Mon, 29 Jul 2024 15:38:19 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> --- .../tests/consistency/row_comparisons/consistency_event.sql | 6 ++++-- .../consistency/row_comparisons/consistency_sessions.sql | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/integration_tests/tests/consistency/row_comparisons/consistency_event.sql b/integration_tests/tests/consistency/row_comparisons/consistency_event.sql index 17fa433..0d2f20e 100644 --- a/integration_tests/tests/consistency/row_comparisons/consistency_event.sql +++ b/integration_tests/tests/consistency/row_comparisons/consistency_event.sql @@ -2,15 +2,17 @@ tags="fivetran_validations", enabled=var('fivetran_validation_tests_enabled', false) ) }} +{% set exclude_fields = ["properties", 'event_properties'] %} +{% set fields = dbt_utils.star(from=ref('mixpanel__event'), except=exclude_fields) %} -- this test ensures the daily_activity end model matches the prior version with prod as ( - select * + select {{ fields }} from {{ target.schema }}_mixpanel_prod.mixpanel__event ), dev as ( - select * + select {{ fields }} from {{ target.schema }}_mixpanel_dev.mixpanel__event ), diff --git a/integration_tests/tests/consistency/row_comparisons/consistency_sessions.sql b/integration_tests/tests/consistency/row_comparisons/consistency_sessions.sql index 70b3517..d47eac5 100644 --- a/integration_tests/tests/consistency/row_comparisons/consistency_sessions.sql +++ b/integration_tests/tests/consistency/row_comparisons/consistency_sessions.sql @@ -2,15 +2,17 @@ tags="fivetran_validations", enabled=var('fivetran_validation_tests_enabled', false) ) }} +{% set exclude_fields = ["event_frequencies"] %} +{% set fields = dbt_utils.star(from=ref('mixpanel__sessions'), except=exclude_fields) %} -- this test ensures the daily_activity end model matches the prior version with prod as ( - select * + select {{ fields }} from {{ target.schema }}_mixpanel_prod.mixpanel__sessions ), dev as ( - select * + select {{ fields }} from {{ target.schema }}_mixpanel_dev.mixpanel__sessions ),