Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel instrumentation & metrics to Firehose #57

Open
10 tasks
bradgessler opened this issue Jun 2, 2016 · 2 comments
Open
10 tasks

Add channel instrumentation & metrics to Firehose #57

bradgessler opened this issue Jun 2, 2016 · 2 comments

Comments

@bradgessler
Copy link
Member

Metrics on the following have been requested for Firehose:

Connection metrics

  • Number of connections
  • Number of connections established
  • Number of closed connections

Channel metrics

  • Number of catch-ups performed
  • Number of "channels"
  • Channels created
  • Channels destroyed
  • Channel pubs
  • Per channel counters(subscribers,events,sizes,etc)

Redis commands

  • Counts on events that cause Redis commands to occur?

Implement these as a module in Firehose. We'll use the same Firehose server to track these metrics.

@bradgessler
Copy link
Member Author

bradgessler commented Jun 2, 2016

@ProTip can the connection metrics be measured from nginx connections? Are you looking for something more specific like WS vs LongPolling vs Multipi-plexing connections?

Also what time intervals are you looking for connections. Connections per second? Connections per minute? The time resolution will need to be known per metric that's to be measured.

@ProTip
Copy link

ProTip commented Jun 3, 2016

It would be beneficial to track the different types of connections/disconnections separately from nginx and from the POV of Firehose.

A lot of what we collect is at 10 second resolution. For the purposes of Firehose it should probably be configurable. We probably don't wan to expose the metrics as rates from Firehose; just the raw counts.

Do you have a strategy for efficiently flushing the metrics from all the Firehose workers to Redis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants