-
Notifications
You must be signed in to change notification settings - Fork 181
Create a GitHub action to publish white labeled ODP Docusaurus content #19
Comments
Per my discussion with @maoo on 2020.1.31 it's my understanding that this is the issue that would address the need to make it much easier for developers to run builds of documentation sites on their forks, such that they can share their WIP (work in progress) with other collaborators in the form of their fork build of the doc site. This has come up with Alloy as there are several people who will be working on the documentation site concurrently and it would be useful to share ideas with each other by showing our build on our fork before doing PRs into the base repo. It sounds like at least part of the work would be to parameterize some of the fields in |
@brooklynrob - I've set up a meeting with @mcleo-d @maoo on Monday to discuss this and a couple of other issues on Microsite / GH UX - and how best to address for users with less technical experience. Plus, we'll discuss some other items that should go into the Documents and branding of microsites (current and future via the microsite blueprint). Thanks |
@grizzwolf @mcleo-d @maoo A good example I thought of when discussing this w/ @toshaellison today was the way in which Riko's fork, https://rikoe.github.io/FDC3/docs/use-cases/overview (no longer up) became our de facto staging/testing/integrate environment during the FDC3 doc site says. Grizz's did too. |
@grizzwolf @mcleo-d @maoo Versioning might be another way to fulfill this. See https://docusaurus.io/docs/en/tutorial-version. This sentence, especially the last part, is what caught my eye: "Versioned documentation helps to show relevant documentation for the current version of a tool and also hide unreleased documentation from users, reducing confusion." -- I am looking for a way to stage/test/show documentation to a small group of reviewers for comment first before releasing it to everyone. |
Another idea for how to implement this (a staging/integration environment in which to stage/evaluate proposed documentation changes) for, say, Alloy.
I.e., use the same build infrastructure and process, and make use of branches and two new hostnames to create 1 or 2 more instances (test and dev). Additionally, probably make process that pull requests are merged into the lowest (i.e., test if there is no dev; otherwise dev) level and then commits promoted as part of the editorial review process. |
Working on a promising spike on https://github.com/maoo/finos-fo/blob/master/PUBLISH_SITE.md Still need to test the PR comment feature, but the build works like a charm and doesn't need any configuration (as opposed to the Travis CI approach we followed so far). When all is tested and working, we will adopt this build on https://github.com/finos/open-developer-platform and test the full PR workflow. |
I believe we're talking about two different features of microsite development on this thread, so have created...
... to follow the in-development microsite feature raised by @brooklynrob. The solution being delivered in this issue #19 is a PR feature that allows project maintainers to review the contents of a microsite PR before accepting the build, which is post development. |
@maoo - Thanks for all the work done ask part of this story 😺 Please move this item to In Progress on the ODP kanban if the story has been picked and in play. https://github.com/orgs/finos/projects/8#card-31823971 Please note, I have raised #60 to capture the requirements of @brooklynrob which could be different to the scope of this story. Thanks buddy 👍 |
Code is done and running, see https://github.com/finos/open-developer-platform/blob/master/docs/docusaurus-build-action.md The comment feature is currently failing with a 403 ; I found a similar issue on danger/danger-js#918 , would be worth asking GitHub how we can make it work. Happy to demo this action during the next ODP meeting! |
Just created #74 and #75 with the issues left, so we can close this one. Docs available on https://finosfoundation.atlassian.net/wiki/spaces/FDX/pages/1411317820/Docusaurus+Build+Action |
Acceptance Criteria
/docs
andwebsite
folders has a comment with a link to the site previewTasks
The text was updated successfully, but these errors were encountered: