Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add a comparison text box for hashes #14891

Open
Josh65-2201 opened this issue Mar 3, 2024 · 5 comments · May be fixed by #16771
Open

Feature: Add a comparison text box for hashes #14891

Josh65-2201 opened this issue Mar 3, 2024 · 5 comments · May be fixed by #16771
Labels
area - properties window Features or bug reports for the file permissions page
Milestone
Files v4

Comments

@Josh65-2201
Copy link
Member

What feature or improvement do you think would benefit Files?

Requirements

  • Add a text input at the bottom of the hash page in properties
  • When entered show matching hash type as text below text input.
    • Alternatively highlight match with green text and show as all red if there is no match

Files Version

3.2.6.0

Windows Version

10.0.22621.3155

Comments

No response
@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Mar 4, 2024
@0x5bfa
Copy link
Member

0x5bfa commented Mar 5, 2024

I don't see usecase. is this for user to check if hashes from two files are the same?

@Josh65-2201
Copy link
Member Author

Josh65-2201 commented Mar 5, 2024 •
edited
Loading

No. Sites usually will have the hash for downloaded files, comparing all but CRC32 one yourself is slow since there long and doesn't fit in the properties window with the default size making a character easily missed.

@0x5bfa 0x5bfa added the area - properties window Features or bug reports for the file permissions page label May 17, 2024
@yaira2
Copy link
Member

yaira2 commented May 30, 2024

We'll need a design for this

@0x5bfa
Copy link
Member

0x5bfa commented May 30, 2024

image
From HashTab app

@yaira2 yaira2 added this to the Files v4 milestone Jan 30, 2025
@yaira2
Copy link
Member

yaira2 commented Jan 30, 2025 •
edited
Loading

@Lamparter there are two aspects to this feature request

  1. A new section with a textbox where users can enter a hash, and Files will display if it's a match for any of the hashes.
  2. A button to compare with another file to check they have the same hash.

I'll keep this under planning as we don't have a design, but the functionality part can be started.

@Lamparter Lamparter linked a pull request Feb 2, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area - properties window Features or bug reports for the file permissions page
Projects
Files task board
Status: 📋 Planning stage
Milestone
Files v4
Development

Successfully merging a pull request may close this issue.

Feature: Added a comparison text box for hashes Lamparter/Files
3 participants
@Josh65-2201 @yaira2 @0x5bfa