Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Method has overload with cancellation support #15095

Open
gumbarros opened this issue Apr 1, 2024 · 0 comments · May be fixed by #16739
Open

Code Quality: Method has overload with cancellation support #15095

gumbarros opened this issue Apr 1, 2024 · 0 comments · May be fixed by #16739

Comments

@gumbarros
Copy link
Contributor

Description

Many methods in the code base supports cancellation and are nothing using the CancellationToken.

Concerned code

<platforms><Files.App>\Services\UpdateService.cs (1 issue)
<platforms><Files.App>\Utils\Storage\Search\FolderSearch.cs (3 issues)
<platforms><Files.App>\Utils\Archives\CompressArchiveModel.cs (1 issue)
<platforms><Files.App>\Services\SideloadUpdateService.cs (1 issue)
<platforms><Files.App>\Utils\Storage\StorageItems\VirtualStorageFile.cs (2 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\NativeStorageFile.cs (7 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\FtpStorageFolder.cs (5 issues)
<platforms><Files.App>\Utils\Storage\Operations\FilesystemOperations.cs (29 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\SystemStorageFile.cs (8 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\ZipStorageFolder.cs (8 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\ZipStorageFile.cs (4 issues)
<platforms><Files.App>\Utils\Storage\StorageBaseItems\BaseStorageFolder.cs (6 issues)
<platforms><Files.App>\Utils\Storage\Operations\FileOperationsHelpers.cs (3 issues)
<platforms><Files.App>\Data\Models\ItemViewModel.cs (5 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\FtpStorageFile.cs (1 issue)
<platforms><Files.App>\Data\Factories\ShellContextFlyoutHelper.cs (1 issue)
<platforms><Files.App>\Helpers\Win32\Win32Helper.Storage.cs (2 issues)
<platforms><Files.App>\Utils\Git\GitHelpers.cs (3 issues)
<platforms><Files.App>\Utils\Storage\StorageItems\StreamWithContentType.cs (2 issues)
<platforms><Files.App>\ViewModels\Properties\Items\FolderProperties.cs (1 issue)
<platforms><Files.App>\ViewModels\Properties\Items\LibraryProperties.cs (1 issue)

Gains

  • Reliability, if the user cancels an operation, the operation will respond faster because of the CancellationToken

Requirements

  • Passing the CancellationToken in the methods specified by the analyzer

Comments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants