Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases are triggered by code review #181

Open
alexytsu opened this issue Jan 9, 2023 · 1 comment
Open

Releases are triggered by code review #181

alexytsu opened this issue Jan 9, 2023 · 1 comment

Comments

@alexytsu
Copy link
Collaborator

alexytsu commented Jan 9, 2023

- The Github CI should be given permissions to publish to crates.io
- Merged results on main should be used
- Tags should be used to trigger the releases and mark the commit that was built

Done Criteria

The to-be-created release steps outlined in filecoin-project/builtin-actors#1566 can be followed without requiring manual clicking in the GitHub UI. Instead, releases should occur as a result of an approved PR.

Why Important

  1. Less time used by maintainers
  2. Not bottleneck on certain folks to publish
  3. Less error prone

User/Customer

Maintainers

Notes

  1. This is more of a standard Rust repo and should be published to crates.io
@BigLep
Copy link
Member

BigLep commented Jul 11, 2024

If I had my permissions, I would change this issue such that:

Issue title

Releases are triggered by code review

Issue description

Done Criteria

The to-be-created release steps outlined in filecoin-project/builtin-actors#1566 can be followed without requiring manual clicking in the GitHub UI. Instead, releases should occur as a result of an approved PR.

Why Important

  1. Less time used by maintainers
  2. Not bottleneck on certain folks to publish
  3. Less error prone

User/Customer

Maintainers

Notes

  1. This is more of a standard Rust repo and should be published to crates.io

@BigLep BigLep changed the title Run package releases off CI Releases are triggered by code review Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants