Failure in messages decoding during TO0 and TO1

[Sai-Anudeep47]

Hi @herrjemand

After building and starting the FIDO Conformance Server in onprem mode, server returns "Failed to decode body" error during TO0 and TO1 protocols specifically message 22 and message 30.

Logs for such errors are attached from both FIDO Conformance Server and from FDO clients.

client_to0_msg22_fail_logs.txt

fdo_conformance_server_to0_logs.txt

client_to1_msg30_fail_logs.txt

fdo_conformance_server_to1_logs.txt

[yackermann]

Hey @Sai-Anudeep47.

Your OwnerSign To0d is not bstr, but CBOR array.

But it must be bstr

https://drafts.fidoalliance.org/internet-of-things-specs/stable-links-to-latest/FIDO-IoT-spec.html#rvblobsendmsg

[GeofCooper]

Looks that way to me, too. @rftemple is taking a look.

Since we have done interop between LF-Edge and RedHat in the past, suggest that @7flying take a look to see if they have the same issue.

Why this is a "bstr .cbor": because you have to run the hash value on the CBOR and put the value into

TO0.OwnerSign.to1d...to1dBlobPayload.to1dTo0dHash

Important: the hash must be computed on the contents of the BSTR, without the bstr wrapper's own cbor encoding. I.e., the first thing included in the hash is the array[2] header 0x82.

[GeofCooper]

This is an issue with at least the LF-Edge implementation.
"Not a bug" for the test suite (actually, good job, Yuriy!)
Please keep this issue open with "wontfix" for now, so we can track the implementations that need fixes.

[7flying]

Reference to RH's issue: fdo-rs/fido-device-onboard-rs#496

[yackermann]

@GeofCooper Super! Let me know if you need any help!

[puiterwijk]

Note that TO0.OwnerSign.to0d used to be a cbor array in v1.0, so this feels like something is sending a v1.0 message to a v1.1 peer.

[pheimfido]

FDO certification will certify implementations [end products (devices), onboarding services (devices), and RV servers] beginning with FDO v1.1. All, will FIDO Certification encounter implementations against FDO v1.0? @GeofCooper @gmandyam @rftemple @puiterwijk @7flying @quanvincss