Merge pull request #146 from ferryproxy/fix/update

wzshiming · web-flow · commit fe04ea4101f0 · 2022-10-08T15:31:02.000+08:00
Fixed multiple updates
diff --git a/pkg/controllers/hub/hub_controller.go b/pkg/controllers/hub/hub_controller.go
@@ -212,6 +212,7 @@ func (c *HubController) updateClientset(hubName string) (client.Interface, error
 
 	if updated {
 		c.enableCache(hubName, clientset)
+		c.checkHealth(hubName)
 	}
 
 	if IsEnabledMCS(hub) {
@@ -327,8 +328,6 @@ func (c *HubController) onAdd(obj interface{}) {
 			"hub", objref.KRef(consts.FerryNamespace, f.Name),
 		)
 	}
-
-	c.checkHealth(f.Name)
 }
 
 func IsEnabledMCS(f *trafficv1alpha2.Hub) bool {
@@ -428,8 +427,6 @@ func (c *HubController) onUpdate(oldObj, newObj interface{}) {
 			"hub", objref.KRef(consts.FerryNamespace, f.Name),
 		)
 	}
-
-	c.checkHealth(f.Name)
 }
 
 func (c *HubController) checkHealth(hubName string) {

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,7 @@ func (c *HubController) updateClientset(hubName string) (client.Interface, error`
`212`	`212`
`213`	`213`	`if updated {`
`214`	`214`	`c.enableCache(hubName, clientset)`
	`215`	`+ c.checkHealth(hubName)`
`215`	`216`	`}`
`216`	`217`
`217`	`218`	`if IsEnabledMCS(hub) {`
`@@ -327,8 +328,6 @@ func (c *HubController) onAdd(obj interface{}) {`
`327`	`328`	`"hub", objref.KRef(consts.FerryNamespace, f.Name),`
`328`	`329`	`)`
`329`	`330`	`}`
`330`		`-`
`331`		`- c.checkHealth(f.Name)`
`332`	`331`	`}`
`333`	`332`
`334`	`333`	`func IsEnabledMCS(f *trafficv1alpha2.Hub) bool {`
`@@ -428,8 +427,6 @@ func (c *HubController) onUpdate(oldObj, newObj interface{}) {`
`428`	`427`	`"hub", objref.KRef(consts.FerryNamespace, f.Name),`
`429`	`428`	`)`
`430`	`429`	`}`
`431`		`-`
`432`		`- c.checkHealth(f.Name)`
`433`	`430`	`}`
`434`	`431`
`435`	`432`	`func (c *HubController) checkHealth(hubName string) {`