Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift http handler type discovery up a layer #2373

Merged
merged 1 commit into from
May 15, 2024
Merged

Lift http handler type discovery up a layer #2373

merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. Lift http handler type discovery up a layer 

    This commit lifts the discovery of what type of handler a component is,
for example spin-vs-wasi-vs-wasi-snapshot, up one layer from where it
currently resides. Previously this determination was made on each
request and now it's made when a component first loaded and
pre-instantiated instead. This would shift possible errors earlier in
the system, for example.

This removes a bit of per-request work and makes the creation of the
handler in `execute_wasi` a bit more straightforward with less guessing
of exports for something that was already probed.

Signed-off-by: Alex Crichton <[email protected]>
    @alexcrichton
    alexcrichton committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e565b78 View commit details
    Browse the repository at this point in the history