Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit workspace metadata #2351

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Inherit workspace metadata #2351

merged 1 commit into from
Mar 13, 2024

Conversation

fibonacci1729
Copy link
Contributor

Fixes #2340

itowlson
itowlson approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so stoked that somebody else was bothered enough by this to actually fix it

@itowlson
Copy link
Contributor

Passed required checks, and the non-required ones have been flaky, so I will merge despite the cancelled checks.

@itowlson itowlson merged commit 7f55409 into fermyon:main Mar 13, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Spin crates are not taking the workspace version
2 participants
@fibonacci1729 @itowlson