Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Key is not set when dependent repository targets a specific commit #366

Open
adduc opened this issue Apr 25, 2017 · 1 comment · May be fixed by #367
Open

Cache Key is not set when dependent repository targets a specific commit #366

adduc opened this issue Apr 25, 2017 · 1 comment · May be fixed by #367
Labels
enhancement size: 1

Comments

@adduc
Copy link

adduc commented Apr 25, 2017

We use a few dependencies in our composer.json that target a specific commit (e.g. dev-master#4b7c20db3c72a859df049701db43659187bc4573). Every time VSCode starts, these dependencies are reparsed, even if no file has changed since the last time VSCode has started. Within the log output, this is seen:

[Warn  - 9:35:35 AM] Could not compute cache key for phing/phing

It looks like the cache key is decided in src/Indexer.php. When a version isn't used, could you cache off of the commit ID (if available)?
@felixfbecker
Copy link
Owner

Sound reasonable. Feel free to do a PR

adduc added a commit to adduc/php-language-server that referenced this issue Apr 26, 2017
@adduc
Cache source packages when reference/revision is available
9438724 
Fixes felixfbecker#366
@adduc adduc linked a pull request Apr 26, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement size: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache source packages when reference/revision is available adduc/php-language-server
2 participants
@adduc @felixfbecker