Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonSerializer.NullValueHandling should be Include #113

Closed
richardszalay opened this issue May 5, 2020 · 0 comments · Fixed by #116
Closed

JsonSerializer.NullValueHandling should be Include #113

richardszalay opened this issue May 5, 2020 · 0 comments · Fixed by #116

Comments

@richardszalay
Copy link

richardszalay commented May 5, 2020

Mandrill.net configures JSON.NET to use NullValueHandling.Ignore, but this causes problems with loops due to the crazy nature of how loop scoping works in Mandrill's handlebars implementation (the specifics of which are covered here and here, the latter of which is from 2016 and shows that the problem is unlikely to be solved by Mandrill any time soon).

I propose changing NullValueHandling to Include since it solves this scenario... for non-array properties.

(Mandrill's array property handling appears to be even worse, requiring a non-empty array to replace the previous iteration's value. The above change will obviously not help with that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant