Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use io swagger 1.5.3 #67

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wakandan
Copy link

In swagger 1.5.3 they added a form to try out json body for post request, very useful

image

Please note the use of this project version 0.7.1 instead of 0.7.1-SNAPSHOT. I'm not very familiar with how maven version is managed in open source project, so please instruct me how to do it properly. Thanks

@jplock
Copy link

jplock commented Aug 21, 2015

@wakandan I'd switch back those version changes. This project uses the maven-release-plugin which handles incrementing the versions in the pom.xml files automatically whenever a new release is created.

@jplock
Copy link

jplock commented Aug 21, 2015

Merging this in will fix #66 and #63. Can you please merge this in @federecio and create a new release?

@wakandan
Copy link
Author

@jplock ah I didn't know about that. I was testing it using my local maven cache. I just need to change the version of dropwizard-swagger to 0.7.1-SNAPSHOT right?

@jplock
Copy link

jplock commented Aug 22, 2015

@wakandan yes correct, just set the dropwizard-swagger package back to 0.7.1-SNAPSHOT

@wakandan
Copy link
Author

@jplock done

@wakandan
Copy link
Author

@jplock also reverted the version of dropwizard-junit to SNAPSHOT in federecio/dropwizard-junit#7

@jplock
Copy link

jplock commented Aug 22, 2015

Looks great, thanks!

@wakandan
Copy link
Author

let's merge so that we can update from mvn guys 👯

@edwardsb
Copy link

When I run maven compile target I see this:

The POM for io.federecio:dropwizard-junit:jar:0.7 is missing, no dependency information available

And I don't see version 0.7 out on maven, only 0.6. Am I missing something? Tests fail because of this missing dependency.

@wakandan
Copy link
Author

@edwardsb 0.7 have not been published yet. There's also a pr for dropwizard-junit waiting to be merged -_-

@edwardsb
Copy link

oh alright now I see that. Thanks for all your help

@wakandan
Copy link
Author

@edwardsb you can try to clone the repo and install it locally. Then you can use 0.7 version...

@jplock
Copy link

jplock commented Aug 26, 2015

@wakandan Just fyi, but dropwizard 0.8.4 should be showing up in Maven Central later tonight. Would you mind upgrading this PR to use that latest version?

@cuzz22000
Copy link

@wakandan My PR #66 was submitted to fix #65 upgrading to io.swagger v1.5.0 was the result. Can you update the unit test so coverage for Optional is included?

@jplock
Copy link

jplock commented Sep 1, 2015

I've forked this repo to https://github.com/smoketurner/dropwizard-swagger and plan to publish it to maven central under the "com.smoketurner" groupId if anyone is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants