-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use io swagger 1.5.3 #67
base: master
Are you sure you want to change the base?
Conversation
@wakandan I'd switch back those version changes. This project uses the maven-release-plugin which handles incrementing the versions in the pom.xml files automatically whenever a new release is created. |
Merging this in will fix #66 and #63. Can you please merge this in @federecio and create a new release? |
@jplock ah I didn't know about that. I was testing it using my local maven cache. I just need to change the version of dropwizard-swagger to 0.7.1-SNAPSHOT right? |
@wakandan yes correct, just set the dropwizard-swagger package back to 0.7.1-SNAPSHOT |
@jplock done |
@jplock also reverted the version of |
Looks great, thanks! |
let's merge so that we can update from mvn guys 👯 |
When I run maven compile target I see this: The POM for io.federecio:dropwizard-junit:jar:0.7 is missing, no dependency information available And I don't see version 0.7 out on maven, only 0.6. Am I missing something? Tests fail because of this missing dependency. |
@edwardsb 0.7 have not been published yet. There's also a pr for dropwizard-junit waiting to be merged -_- |
oh alright now I see that. Thanks for all your help |
@edwardsb you can try to clone the repo and install it locally. Then you can use 0.7 version... |
@wakandan Just fyi, but dropwizard 0.8.4 should be showing up in Maven Central later tonight. Would you mind upgrading this PR to use that latest version? |
I've forked this repo to https://github.com/smoketurner/dropwizard-swagger and plan to publish it to maven central under the "com.smoketurner" groupId if anyone is interested. |
In swagger 1.5.3 they added a form to try out json body for post request, very useful
Please note the use of this project version
0.7.1
instead of0.7.1-SNAPSHOT
. I'm not very familiar with how maven version is managed in open source project, so please instruct me how to do it properly. Thanks