Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate benefits of marble testing #112

Open
j2L4e opened this issue May 26, 2018 · 2 comments
Open

Evaluate benefits of marble testing #112

j2L4e opened this issue May 26, 2018 · 2 comments

Comments

@j2L4e
Copy link
Collaborator

j2L4e commented May 26, 2018

See https://github.com/ReactiveX/rxjs/blob/master/doc/marble-testing.md

The current tests are hard to reason about and some use hacky setTimeouts just to make it work.

This could possibly be improved by using marbles.

@stale
Copy link

stale bot commented Aug 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Apologies if the issue could not be resolved. FeathersJS ecosystem modules are community maintained so there may be a chance that there isn't anybody available to address the issue at the moment. For other ways to get help see here.

@stale stale bot added the wontfix label Aug 18, 2018
@stale stale bot closed this as completed Aug 25, 2018
@daffl daffl added enhancement and removed wontfix labels Aug 25, 2018
@daffl
Copy link
Member

daffl commented Aug 25, 2018

Oops... forgot to add the label to keep this open.

@daffl daffl reopened this Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants