Skip to content

Commit 99c84da

Browse files
committed
Fix serialize_entity_key to handle empty entities (#5628)
Signed-off-by: Jacob Weinhold <[email protected]>
1 parent 38d7fd1 commit 99c84da

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

sdk/python/feast/infra/key_encoding_utils.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,16 @@ def serialize_entity_key(
142142
"Serialization of entity key with version < 3 is removed. Please use version 3 by setting entity_key_serialization_version=3."
143143
"To reserializa your online store featrues refer - https://github.com/feast-dev/feast/blob/master/docs/how-to-guides/entity-reserialization-of-from-v2-to-v3.md"
144144
)
145-
sorted_keys, sorted_values = zip(
146-
*sorted(zip(entity_key.join_keys, entity_key.entity_values))
147-
)
145+
146+
sorted_keys: List[str]
147+
sorted_values: List[ValueProto]
148+
if not entity_key.join_keys:
149+
sorted_keys = []
150+
sorted_values = []
151+
else:
152+
pairs = sorted(zip(entity_key.join_keys, entity_key.entity_values))
153+
sorted_keys = [k for k, _ in pairs]
154+
sorted_values = [v for _, v in pairs]
148155

149156
output: List[bytes] = []
150157
if entity_key_serialization_version > 2:

0 commit comments

Comments
 (0)