Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

未实现图片功能 #1

Open
honguangli opened this issue Dec 17, 2020 · 1 comment
Open

未实现图片功能 #1

honguangli opened this issue Dec 17, 2020 · 1 comment

Comments

@honguangli
Copy link

您好,我下载了这份代码,似乎您还没有实现完官方案例所提供的功能。
目前我发现了一些问题
1)插入图片,您定义的数据结构似乎有些问题。
model.Sheet.Images字段您定义为“interface{}”类型,这并不准确,并将导致luckysheet无法正确处理图片功能,我认为应该定义为map[string]*Image类型,这与luckysheet所引用的images结构才是一致的。
另外,model.Sheet结构中还有一个与Images类似命名的Image字段,目前我还没发现它的作用是什么?
2)websocket协同方面,您似乎忽略了心跳包类型?当前端发送“rub”消息时go代码将其广播给了所有协同用户,这导致前端json解析时异常。您应该捕获它并消费掉。

@fandypeng
Copy link
Owner

fandypeng commented Dec 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants